From: Chunyan Liu Date: Thu, 7 Apr 2016 09:40:25 +0000 (+0800) Subject: libxl: fix rc handling in libxl_device_usbdev_list X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~1343 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f07d02f1c421f722144e899331ad91ab0ccee9eb;p=xen.git libxl: fix rc handling in libxl_device_usbdev_list In testing with libvirt pvusb functionality, found a rc check error in libxl_device_usbdev_list. Correct it. This function is not used by xl. Signed-off-by: Chunyan Liu CC: Simon Cao CC: George Dunlap Acked-by: Ian Jackson --- diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c index d04cb93fad..f69792a12c 100644 --- a/tools/libxl/libxl_pvusb.c +++ b/tools/libxl/libxl_pvusb.c @@ -751,13 +751,13 @@ libxl_device_usbdev_list(libxl_ctx *ctx, uint32_t domid, int *num) usbctrls = libxl__xs_directory(gc, XBT_NULL, path, &nc); for (i = 0; i < nc; i++) { - int r, nd = 0; + int rc, nd = 0; libxl_device_usbdev *tmp = NULL; - r = libxl__device_usbdev_list_for_usbctrl(gc, domid, + rc = libxl__device_usbdev_list_for_usbctrl(gc, domid, atoi(usbctrls[i]), &tmp, &nd); - if (!r || !nd) continue; + if (rc || !nd) continue; usbdevs = libxl__realloc(NOGC, usbdevs, sizeof(*usbdevs) * (*num + nd));